feat: making iam endpoint universe-aware #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Use monkeypatch to test whether the correct urls are used. One place to do is test_sign_bytes in test_impersonated_credentials.py. For example, follow pattern in test__get_explicit_environ_credentials in test__default.py |
sai-sunder-s
requested changes
Oct 18, 2024
sai-sunder-s
requested changes
Oct 18, 2024
sai-sunder-s
requested changes
Oct 18, 2024
| id_creds = impersonated_credentials.IDTokenCredentials( | ||
| credentials, target_audience=target_audience, include_email=True | ||
| ) | ||
| id_creds = id_creds.from_credentials(target_credentials=new_credentials) | ||
| id_creds = id_creds.from_credentials(target_credentials=target_credentials) |
There was a problem hiding this comment.
why is this line existing? IIUC, removing this will have no impact.
There was a problem hiding this comment.
It seems to remove the target_audience?
| credentials = self.make_credentials( | ||
| lifetime=None, source_credentials=source_credentials | ||
| ) | ||
| target_credentials = self.make_credentials( |
There was a problem hiding this comment.
why is same cred created 2 times?
sai-sunder-s
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Impersonated credential support of universe domain. So they call endpoint in proper universes.