Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Python 3.12 #1421

Merged
merged 6 commits into from
Nov 29, 2023
Merged

feat: Add support for Python 3.12 #1421

merged 6 commits into from
Nov 29, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Nov 24, 2023

No description provided.

@parthea
Copy link
Contributor Author

parthea commented Nov 24, 2023

Wait for cl/585092331

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2023
@parthea parthea marked this pull request as ready for review November 28, 2023 16:57
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2023
@parthea parthea requested review from a team as code owners November 28, 2023 16:57
@parthea parthea requested a review from nicain November 28, 2023 16:57
engelke
engelke approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit 307916c into main Nov 29, 2023
16 checks passed
@engelke engelke deleted the add-python-3.12 branch November 29, 2023 00:23
@release-please release-please bot mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clundin25 clundin25 clundin25 approved these changes

@engelke engelke engelke approved these changes

@nicain nicain Awaiting requested review from nicain nicain is a code owner automatically assigned from googleapis/python-samples-owners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthea @engelke @clundin25