-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate getRequestMetadata #414
chore: deprecate getRequestMetadata #414
Conversation
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
========================================
- Coverage 95.15% 95% -0.15%
========================================
Files 15 15
Lines 970 981 +11
Branches 217 217
========================================
+ Hits 923 932 +9
- Misses 47 49 +2
Continue to review full report at Codecov.
|
src/auth/jwtaccess.ts
Outdated
@@ -14,19 +14,25 @@ | |||
* limitations under the License. | |||
*/ | |||
|
|||
import {IncomingHttpHeaders} from 'http'; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
gentle ping @google/google-node-team @google/yoshi-nodejs |
BREAKING CHANGE: The
getRequestMetadata
method has been deprecated on theIAM
,OAuth2
,JWT
, andJWTAccess
classes. ThegetRequestHeaders
method should be used instead. The methods have a subtle difference: thegetRequestMetadata
method returns an object with a headers property, which contains the authorization header. ThegetRequestHeaders
method simply returns the headers.Old code
New code