BREAKING CHANGE: export class types and remove properties from GoogleAuth #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ofrobots
approved these changes
Dec 1, 2017
There was a problem hiding this comment.
LGTM with a few nits:
- As per https://conventionalcommits.org/ the body or the footer should have the 'BREAKING CHANGE' prefix, not the title.
- Since you didn't change package.json, it is preferable not to include the delta to package-lock.json in the patch, unless you had an explicit intent to upgrade the deps. If possible, drop that file from the patch. That will make cherry-picking / reverting / rebasing easier going forward.
BREAKING CHANGE: The IAMAuth, Compute, JWT, JWTAccess, OAuth2, and UserRefreshClient types are no longer available as public properties on the GoogleAuth object. They are now exported directly from the top level module.
|
Good feedback :) Addressed all the things! |
ofrobots
pushed a commit
that referenced
this pull request
Jan 9, 2018
BREAKING CHANGE: The IAMAuth, Compute, JWT, JWTAccess, OAuth2, and UserRefreshClient types are no longer available as public properties on the GoogleAuth object. They are now exported directly from the top level module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing samples, I noticed that today I need to instantiate a new
GoogleAuth, then from that instance you get access to the types needed to create newJWT,UserRefreshClient, andOAuth2Clientobjects. That's silly. Instead, I just added them to the exports on the index.