Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: checkIsGCE: report unexpected errors #164

Merged
merged 1 commit into from
Sep 8, 2017
Merged

fix: checkIsGCE: report unexpected errors #164

merged 1 commit into from
Sep 8, 2017

Conversation

ofrobots
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 17, 2017
@coveralls
Copy link

coveralls commented Aug 17, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 93.552% when pulling cdb5cad on ofrobots:is-gce into e89977f on google:master.

@ofrobots
Copy link
Contributor Author

The main reason I put this together is that I am seeing reports of 'Unable to acquire ADC' on GCF environments. The expectation is that these are socket timeouts, but it would be good to know the precise error. The existing code was unable to distinguish expected and unexpected error in DNS resolution.

@ofrobots ofrobots requested review from jmdobry and bantini September 7, 2017 14:24
@ofrobots ofrobots merged commit 0a810e4 into googleapis:master Sep 8, 2017
@ofrobots ofrobots deleted the is-gce branch September 8, 2017 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bantini bantini bantini approved these changes

@jmdobry jmdobry jmdobry approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ofrobots @coveralls @jmdobry @bantini @googlebot