-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support transport and binding-enforcement MDS parameters. #1558
Merged
+224
−1
Merged
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
91dba11
Support transport and binding-enforcement MDS parameters.
rmehta19 ba11e8a
add some tests.
rmehta19 47ec152
Merge branch 'main' into mds-cred-token-req-param
rmehta19 9d46bbd
null or empty.
rmehta19 3cb6e98
no default value in builder.
rmehta19 cb70556
Merge branch 'main' into mds-cred-token-req-param
rmehta19 4d0440b
Merge branch 'main' into mds-cred-token-req-param
rmehta19 c96df22
use enums to hold possible Transport + BindingEnforcement types
rmehta19 a625889
Merge branch 'main' into mds-cred-token-req-param
rmehta19 3d46963
Enum labels + Transport -> AuthTransport.
rmehta19 f36a19c
separate constant with underscore.
rmehta19 8a2d967
add javadocs + getTransport -> getAuthTransport.
rmehta19 ce74e45
add test both params null.
rmehta19 8ce3a4d
AuthTransport -> GoogleAuthTransport.
rmehta19 838380f
Merge branch 'main' into mds-cred-token-req-param
rmehta19 e921991
Merge branch 'main' into mds-cred-token-req-param
rmehta19 20964e2
add some javadoc.
rmehta19 94618e0
move javadoc to GoogleAuthTransport javadoc.
rmehta19 9261fe8
clean up comments.
rmehta19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this into the javadocs for GoogleAuthTransport so it can be referenced for users in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.