Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using v2 error messages + fix to_json signature #583

Merged
merged 1 commit into from
May 24, 2017
Merged

Allow using v2 error messages + fix to_json signature #583

merged 1 commit into from
May 24, 2017

Conversation

sqrrrl
Copy link
Contributor

@sqrrrl sqrrrl commented May 19, 2017

Adds opt-in to use v2 error messages (#544). Also fixes the to_json signature for compatibility with the json gem (#576)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 96.31% when pulling 6a4e918 on sqrrrl:master into 271f0c8 on google:master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 96.31% when pulling 6a4e918 on sqrrrl:master into 271f0c8 on google:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 96.31% when pulling 6a4e918 on sqrrrl:master into 271f0c8 on google:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 96.31% when pulling 6a4e918 on sqrrrl:master into 271f0c8 on google:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 96.31% when pulling 6a4e918 on sqrrrl:master into 271f0c8 on google:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 96.31% when pulling 6a4e918 on sqrrrl:master into 271f0c8 on google:master.

@sqrrrl sqrrrl requested a review from saicheems May 23, 2017 22:26
@saicheems
Copy link
Contributor

lgtm

@qingling128
Copy link

Hi, Is this ready for merge? :)

@sqrrrl sqrrrl merged commit 84f4c7f into googleapis:master May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saicheems saicheems saicheems approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sqrrrl @coveralls @saicheems @qingling128 @googlebot