-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't set http.redirect_codes if the attr doesn't exist #841
Conversation
Could we also change install requires to be similar to before like: |
Made the change to setup.py. Is it possible for your tests to pin to an older version of this library until you're able to sort out upgrading httplib2? Or is there a requirement for you to always be testing with the latest version of google-api-python-client? |
I don't there is a requirement to use at head. This is our setup file (https://github.com/apache/beam/blob/master/sdks/python/setup.py) -- I cannot find a direct dependency. Probably there is some indirect dependency. |
Thank you all! When would this change be available in pypi? |
Just looking for an approval on the release PR(#842) and then I'll push it out to PyPI. :) |
1.8.0 is released @aaltay https://pypi.org/project/google-api-python-client/1.8.0/ |
Thank you very much for the quick response! |
This allows folks who can't upgrade their httplib2 version to use the latest version of the library. Note that it is still strongly recommended that you upgrade (see install_requires).
@aaltay is there an issue tracking the httplib2 upgrade I can link to? I'd like this to be removed eventually.