Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tox.ini: Look for Python syntax errors and undefined names #721

Merged
merged 1 commit into from
Jul 22, 2019
Merged

tox.ini: Look for Python syntax errors and undefined names #721

merged 1 commit into from
Jul 22, 2019

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 21, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 21, 2019
@busunkim96 busunkim96 merged commit 317f6ab into googleapis:master Jul 22, 2019
@cclauss cclauss deleted the patch-3 branch July 22, 2019 17:52
@tseaver
Copy link
Contributor

tseaver commented Jul 22, 2019

Hmm, we don't have tox running on CI?

@busunkim96
Copy link
Contributor

The Kokoro job runs tox -- I made the mistake of forgetting to add kokoro label to make the CI run here. Fixed lint errors as part of #724

@vorpal-buildbot vorpal-buildbot mentioned this pull request Jul 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cclauss @tseaver @busunkim96 @googlebot