-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pycrypto. #692
Closed
Closed
Remove pycrypto. #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jun 10, 2019
Honestly both of these libraries are problematic. We should just move to |
busunkim96
changed the title
Use pycryptodome instead of pycrypto.
Use cryptography instead of pycrypto.
Jun 10, 2019
Well now I'm curious what the dependency was doing at all. 🤷♀ |
:) I was about to ask what pycrypto was used for. There are 3 places PyCrypto is mentioned:
If you don't have any concerns, I'll probably delete it. 🤷♀️ |
Do it.
…On Mon, Jun 10, 2019, 5:09 PM Bu Sun Kim ***@***.***> wrote:
:) I was about to ask what pycrypto was used for.
There are 3 places PyCrypto is mentioned:
1. tox.ini
2. README
<https://github.com/googleapis/google-api-python-client/blob/d82f3e76180bf822fc01f362e5a119988d896432/README.md#third-party-libraries-and-dependencies>
as a development dependency
3. Changelog:
https://github.com/googleapis/google-api-python-client/blob/ffea1a7fe9d381d23ab59048263c631cc2b45323/CHANGELOG#L323-L328
If you don't have any concerns, I'll probably delete it. 🤷♀
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#692?email_source=notifications&email_token=AAB5I47XIOBNORDLRH5DWT3PZ3UJ3A5CNFSM4HWX24XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLR5XQ#issuecomment-500637406>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB5I45WGHMV3UOYD7SBHHLPZ3UJ3ANCNFSM4HWX24XA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #653.