-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new example to the Search Console sample #212
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I am a Google employee signed with my google email, what should I do to get the cla flag on? |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
I linked the commit with my google email this time. Does it work out now? |
CLAs look good, thanks! |
Take a look at your author and committer information ( |
It wasn't at first, but I changed it. This is what I got: Thanks |
Yes, I see something else. Let's make sure we're talking about the same thing though: I'm looking at 31669ef82c70517a which is what I currently see at the head of your fork's master branch. Note the text "@haymigoogle wants to merge 1 commit into google:master from haymigoogle:master" at the top of this page - what matters is what you've pushed to your fork on GitHub, and this may not be the same as what you're seeing on your local machine. |
Hope this works out now :) |
Thanks for the change! |
Until now, code that depended on PyCrypto or OpenSSL was defined conditionally (e.g. indented) in `crypt.py`. Rather than grouping all these together, we factor out the library specific behavior into standalone modules (but make the modules private / protected). In addition, added a `_helpers.py` module with common behavior that was previously defined in multiple places. Finally, beefed up some test cases so that the three newly added modules had 100% test coverage. Towards googleapis#212.
No description provided.