Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new example to the Search Console sample #212

Merged
merged 1 commit into from
Apr 6, 2016

Conversation

haymigoogle
Copy link
Contributor

No description provided.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 3, 2016
@haymigoogle
Copy link
Contributor Author

I am a Google employee signed with my google email, what should I do to get the cla flag on?
Thanks.

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@haymigoogle
Copy link
Contributor Author

I linked the commit with my google email this time. Does it work out now?

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 3, 2016
@nathanielmanistaatgoogle
Copy link
Contributor

Take a look at your author and committer information (git log --pretty=fuller) - they're showing an email address that probably isn't the email address you want associated with your commit.

@haymigoogle
Copy link
Contributor Author

It wasn't at first, but I changed it. This is what I got:
Author: Haymi Shalom haymi@google.com
AuthorDate: Sun Apr 3 15:54:50 2016 +0300
Commit: Haymi Shalom haymi@google.com
CommitDate: Sun Apr 3 15:54:50 2016 +0300
Do you see something else?

Thanks

@nathanielmanistaatgoogle
Copy link
Contributor

Yes, I see something else.

Let's make sure we're talking about the same thing though: I'm looking at 31669ef82c70517a which is what I currently see at the head of your fork's master branch.

Note the text "@haymigoogle wants to merge 1 commit into google:master from haymigoogle:master" at the top of this page - what matters is what you've pushed to your fork on GitHub, and this may not be the same as what you're seeing on your local machine.

@haymigoogle
Copy link
Contributor Author

Hope this works out now :)

@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit 133b9ff into googleapis:master Apr 6, 2016
@nathanielmanistaatgoogle
Copy link
Contributor

Thanks for the change!

akrherz pushed a commit to akrherz/google-api-python-client that referenced this pull request Apr 1, 2019
Until now, code that depended on PyCrypto or OpenSSL was
defined conditionally (e.g. indented) in `crypt.py`. Rather than
grouping all these together, we factor out the library specific
behavior into standalone modules (but make the modules
private / protected).

In addition, added a `_helpers.py` module with common behavior
that was previously defined in multiple places.

Finally, beefed up some test cases so that the three newly added
modules had 100% test coverage.

Towards googleapis#212.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants