test: Support running the test suite without oauth2client #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the inheritance of MockCredentials from oauth2client.Credentials. This is unnecessary, and removing it makes it possible to run the respective tests without oauth2client installed.
Make it possible to run the test suite without oauth2client, by skipping the few tests that specifically require it. Given that oauth2client is deprecated, we are aiming towards removing it entirely from Gentoo and the unconditional imports in the test suite are a blocker for that.
gcf-owl-bot
bot
removed
the
owlbot:run
parthea
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
kokoro:run
parthea
approved these changes
Jan 5, 2023
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to run the test suite without oauth2client, by skipping the few tests that specifically require it. Given that oauth2client is deprecated, we are aiming towards removing it entirely from Gentoo and the unconditional imports in the test suite are a blocker for that.
I've also added running without oauth2client as an additional nox scenarios but I can remove that if you prefer.