Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle SSL errors with retries #160

Merged
merged 1 commit into from
Dec 22, 2015
Merged

Handle SSL errors with retries #160

merged 1 commit into from
Dec 22, 2015

Conversation

rryk
Copy link
Contributor

@rryk rryk commented Dec 15, 2015

This is a re-created pull request #159 to make sure that commit author and pull requests are the same accounts so that CLA bot is not confused. This is going to address issues #71, #97, #158.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2015
nathanielmanistaatgoogle
nathanielmanistaatgoogle reviewed Dec 19, 2015
View reviewed changes
tests/test_http.py
self.assertEqual({u'foo': u'bar'}, response)

def test_retry_ssl_errors_resumable(self):
f = open(datafile('small.png'), 'rb')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@nathanielmanistaatgoogle
Copy link
Contributor

Sorry for the delay on this latest round of review.

@nathanielmanistaatgoogle
Copy link
Contributor

Content looks good but please squash commits - there's no need for typo-correction-during-code-review to be its own unique part of project history. :-P

@rryk
Copy link
Contributor Author

rryk commented Dec 21, 2015

Done.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 21, 2015
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 21, 2015
@rryk
Copy link
Contributor Author

rryk commented Dec 21, 2015

Done. Sorry for the CLA complaint above. I have many machines with varying configs for the user.name and user.email. This time I pushed from the wrong one, but quickly re-pushed.

nathanielmanistaatgoogle added a commit that referenced this pull request Dec 22, 2015
@nathanielmanistaatgoogle
Merge pull request #160 from rryk/master
d83246e 
Handle SSL errors with retries.
@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit d83246e into googleapis:master Dec 22, 2015
@nathanielmanistaatgoogle
Copy link
Contributor

Thanks for the contribution!

@eesheesh eesheesh mentioned this pull request Feb 7, 2016
Closed
ethanbao pushed a commit to ethanbao/google-api-python-client that referenced this pull request Mar 2, 2016
@nathanielmanistaatgoogle @ethanbao
Merge pull request googleapis#160 from rryk/master
6f2314b 
Handle SSL errors with retries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rryk @nathanielmanistaatgoogle @googlebot