Node.js usable auth #323
Closed
Node.js usable auth #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogleapis rather than auth
|
There are many styling and code org issues, but we should initially focus on the public APIs. A doc that explains the public APIs and some snippets that would illustrate the usage would be nice to begin with. The implementation will follow. |
| * Determines whether the current operating system is Windows. | ||
| * @api private | ||
| * */ | ||
| GoogleCredentials.prototype._isWindows = function() { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
added 8 commits
November 19, 2014 13:42
…wrappers to the GoogleCredentials class
|
This PR requires significant rework and design improvements. I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Now with all jslint issues fixed.)
This pull request extends the auth portion of the client library to add the usable auth pattern for service accounts. This allows the user to create a few lines of code which will correctly set up a credential client no matter whether the code is running in GAE, GCE, a managed VM, or on a local dev machine.
See https://developers.google.com/accounts/docs/application-default-credentials for more information about usable auth.
See the examples/default_auth.js file for an example of how usable auth works in Node after this checkin.
All unit tests pass, in addition to many new tests to cover to new code.
Thanks!