Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: npm install before running sample tests and avoid symlink in tests #2378

Merged

Conversation

elierotenberg
Copy link
Contributor

  • Always npm install samples/package.json before running sample tests
  • Copy, rather than symlink, in test.samples.auth

Partially fixes #2377.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2377 🦕

* Always `npm install` samples/package.json before running sample tests
* Copy, rather than symlink, in `test.samples.auth`

Partially fixes googleapis#2377.
@elierotenberg elierotenberg requested a review from a team as a code owner October 1, 2020 14:39
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2020
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #2378 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2378   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files          11       11           
  Lines        1714     1714           
  Branches       99       99           
=======================================
  Hits         1463     1463           
  Misses        251      251           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f675e7b...529165a. Read the comment docs.

@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2020
@JustinBeckwith JustinBeckwith changed the title fix: contributing build build: npm install before running sample tests and avoid symlink in tests Oct 28, 2020
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2020
@JustinBeckwith JustinBeckwith merged commit 646053c into googleapis:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Following Contributing docs fails locally
5 participants