Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release google-api-java-client v1.29.0 #1261

Merged

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented May 20, 2019

This pull request was generated using releasetool.

05-20-2019 10:18 PDT

Implementation Changes

  • Deprecate the GoogleCredential and CloudShellCredential classes (#1258)
  • More OSGI metadata (#1253)
  • Fix OSGI metadata for gson and jackson2 packages (#1251)
  • Fix Replaced invalidateToken method to clearToken (#1243)
  • Infinite cycle with MediaHttpDownloader setContentRange download (#1242)
  • Check for null to prevent autoboxing NPE. (#1241)
  • Changed to Guava ByteStreams.copy() that has a bit better performance (#1239)

New Features

  • Add automatic module name (#1235)

Dependencies

  • Update http/oauth dependencies to 1.29 (#1259)

Documentation

  • Fix doc links to googleapis.dev (#1257)
  • Bring comment in line with code (#1246)

Internal / Testing Changes

  • Add publish_javadoc kokoro job (#1248)

@chingor13 chingor13 requested a review from a team as a code owner May 20, 2019 17:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2019
@chingor13 chingor13 merged commit ca51460 into googleapis:master May 20, 2019
@chingor13 chingor13 deleted the release-google-api-java-client-v1.29.0 branch May 20, 2019 18:11
@chingor13
Copy link
Collaborator Author

@mitcoding
Copy link

Forcing users to use "GoogleCredentials" the in the new google-auth-library-java, by deprecating the GoogleCredential class in this package means that it can not longer be used to create HttpRequestFactory by calling methods like urlFetchTransport.createRequestFactory(googleCredential). Because the new GoogleCredentials Class only impliments Serializable. Not HttpExecuteInterceptor, HttpRequestInitializer and HttpUnsuccessfulResponseHandler interfaces, which methods like urlFetchTransport.createRequestFactory in the google api client expect.

It seems pre-mature to deprecate the GoogleCredential class when the rest of this very client api library expects what interfaces GoogleGredential implements in order to function correctly and the replacement class doesn't even come close to implementing the interfaces that the current GoogleCredential class implements and is required by the vary apis in this package.

@chingor13
Copy link
Collaborator Author

@mitcoding google-auth-library-java provides com.google.auth.http.HttpCredentialsAdapter which wraps the credentials and should be used as an implementation for com.google.api.client.http.HttpRequestInitializer and com.google.api.client.http.HttpUnsuccessfulResponseHandler

@mitcoding
Copy link

@chingor13 Using that class worked in resolving the compile time issue. however it still isn't a one to one replacement for App Engine. I'm now getting "Caused by: java.io.IOException: The Application Default Credentials are not available. They are available if running in Google Compute Engine. Otherwise, the environment variable GOOGLE_APPLICATION_CREDENTIALS must be defined pointing to a file defining the credentials. See https://developers.google.com/accounts/docs/application-default-credentials for more information."

Even when I call: AppEngineCredentials.getApplicationDefault();

This was not an issue when using the older now deprecated API "GoogleCredential.getApplicationDefault()".

@chingor13
Copy link
Collaborator Author

@mitcoding Please file this as an issue and we can figure out what's going on. google-auth-library should be able to handle all everything the deprecated class was providing.

@mitcoding
Copy link

@chingor13 Should the I file the issue on google-api-java or the google-auth-library?

@chingor13
Copy link
Collaborator Author

@mitcoding File it on google-auth-library as it seem like the credentials are failing to load for you before it's even making the request from the api client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants