Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3822: Added contentOffset to MediaHttpUploader #1219

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,15 @@ public enum UploadState {
*/
private boolean disableGZipContent;

/**
* Content offset for this uploader.
*
* <p>
* The default value is {@code -1}.
* </p>
*/
private long contentOffset = -1;

/** Sleeper. **/
Sleeper sleeper = Sleeper.DEFAULT;

Expand Down Expand Up @@ -351,6 +360,7 @@ private HttpResponse directUpload(GenericUrl initiationRequestUrl) throws IOExce
initiationRequestUrl.put("uploadType", "multipart");
} else {
initiationRequestUrl.put("uploadType", "media");
initiationRequestUrl.put("contentOffset", String.valueOf(contentOffset));
andrey-qlogic marked this conversation as resolved.
Show resolved Hide resolved
}
HttpRequest request =
requestFactory.buildRequest(initiationRequestMethod, initiationRequestUrl, content);
Expand Down Expand Up @@ -850,6 +860,25 @@ public MediaHttpUploader setDisableGZipContent(boolean disableGZipContent) {
return this;
}

/**
* Returns content Offset for the uploader.
*
* @since 1.27
*/
public long getContentOffset() {
return contentOffset;
}

/**
* Set content Offset for the uploader.
*
* @since 1.27
*/
public MediaHttpUploader setContentOffset(long contentOffset) {
this.contentOffset = contentOffset;
return this;
}

/**
* Returns the sleeper.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ public abstract class AbstractGoogleClientRequest<T> extends GenericData {
/** Whether to disable GZip compression of HTTP content. */
private boolean disableGZipContent;

/** Content offset long the request for media uploader. */
private long contentOffset = -1;

/** Response class to parse into. */
private Class<T> responseClass;

Expand Down Expand Up @@ -223,6 +226,17 @@ public AbstractGoogleClientRequest<T> setDisableGZipContent(boolean disableGZipC
return this;
}

/** Gets content offset. */
public long getContentOffset() {
return contentOffset;
}

/** Sets content offset. */
public AbstractGoogleClientRequest<T> setContentOffset(long contentOffset) {
this.contentOffset = contentOffset;
return this;
}

/** Returns the HTTP method. */
public final String getRequestMethod() {
return requestMethod;
Expand Down Expand Up @@ -505,7 +519,9 @@ private HttpResponse executeUnparsed(boolean usingHead) throws IOException {
boolean throwExceptionOnExecuteError = httpRequest.getThrowExceptionOnExecuteError();

response = uploader.setInitiationHeaders(requestHeaders)
.setDisableGZipContent(disableGZipContent).upload(httpRequestUrl);
.setDisableGZipContent(disableGZipContent)
.setContentOffset(contentOffset)
.upload(httpRequestUrl);
response.getRequest().setParser(getAbstractGoogleClient().getObjectParser());
// process any error
if (throwExceptionOnExecuteError && !response.isSuccessStatusCode()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public class MediaHttpUploaderTest extends TestCase {
private static final String TEST_RESUMABLE_REQUEST_URL =
"http://www.test.com/request/url?uploadType=resumable";
private static final String TEST_DIRECT_REQUEST_URL =
"http://www.test.com/request/url?uploadType=media";
"http://www.test.com/request/url?uploadType=media&contentOffset=-1";
private static final String TEST_MULTIPART_REQUEST_URL =
"http://www.test.com/request/url?uploadType=multipart";
private static final String TEST_UPLOAD_URL = "http://www.test.com/media/upload/location";
Expand Down