feat(option/internaloption): add WithDefaultMTLSEndpointTemplate #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
quartzmo
commented
Nov 19, 2024
quartzmo
commented
- Add DefaultMTLSEndpointTemplate to internal/settings.go
- Deprecate internaloption.WithDefaultMTLSEndpoint
* Add DefaultMTLSEndpointTemplate to internal/settings.go * Deprecate internaloption.WithDefaultMTLSEndpoint
quartzmo
added a commit
to googleapis/google-cloud-go
that referenced
this pull request
Nov 20, 2024
* Remove EXPERIMENTAL field DefaultMTLSEndpoint from httptransport.InternalOptions * Add EXPERIMENTAL field DefaultMTLSEndpointTemplate to httptransport.InternalOptions * Remove EXPERIMENTAL field DefaultMTLSEndpoint from grpctransport.InternalOptions * Add EXPERIMENTAL field DefaultMTLSEndpointTemplate to grpctransport.InternalOptions refs: googleapis/google-api-go-client#2880
quartzmo
added a commit
to quartzmo/google-cloud-go
that referenced
this pull request
Nov 20, 2024
* Remove EXPERIMENTAL field DefaultMTLSEndpoint from httptransport.InternalOptions * Add EXPERIMENTAL field DefaultMTLSEndpointTemplate to httptransport.InternalOptions * Remove EXPERIMENTAL field DefaultMTLSEndpoint from grpctransport.InternalOptions * Add EXPERIMENTAL field DefaultMTLSEndpointTemplate to grpctransport.InternalOptions * Remove runtime error for mTLS usage with non-GDU universe domain. refs: googleapis/google-api-go-client#2880
|
Because the new internal options "template" is set in google-cloud-go/pull/11159 from the old external options "endpoint", this means the |
quartzmo
added a commit
to googleapis/google-cloud-go
that referenced
this pull request
Nov 21, 2024
* remove runtime error for mTLS usage with non-GDU universe domain * add UNIVERSE_DOMAIN placeholder support for Options.DefaultMTLSEndpoint refs: googleapis/google-api-go-client#2880
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.