feat(gensupport): per-chunk transfer timeout configs #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritone
reviewed
Nov 11, 2024
Tulsishah
force-pushed
the
transfertimeout_init
branch
from
f81a9ee to
f54010a
Compare
Tulsishah
force-pushed
the
transfertimeout_init
branch
from
f54010a to
007f67a
Compare
Tulsishah
force-pushed
the
transfertimeout_init
branch
from
007f67a to
c9d6842
Compare
Tulsishah
force-pushed
the
transfertimeout_init
branch
from
40ba714 to
00ceb49
Compare
codyoss
reviewed
Nov 20, 2024
There was a problem hiding this comment.
LGTM to me overall, I will wait for @tritone to fully sign-off. I will say this function is starting to get a bit long and complex. I would consider breaking up the loop body into some different functions can be better documented. Then you can use things like defer again too.
tritone
approved these changes
Nov 20, 2024
It's a good point; I can do this in a subsequent PR. |
codyoss
approved these changes
Nov 20, 2024
codyoss
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(gensupport): per-chunk transfer timeout configs
Allow users to configure the per-chunk transfer timeout for retries
that's used during resumable uploads.
Needs to be exposed via the manual layer for storage.
Tested the feature(with default timeout and with some random value) with storagetestbench server emulator.