Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding import references in examples/customsearch #1399

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

zalgonoise
Copy link
Contributor

@zalgonoise zalgonoise commented Jan 15, 2022

fix: Adding import references in examples/customsearch

Missing alias for the customsearch import statement will cause its references to raise errors. This type of package reference is also found in every other example, with similar import statements ({package}/{version})

Missing alias for the `customsearch` import statement will cause its references to raise errors
@zalgonoise zalgonoise requested review from yoshi-approver and a team as code owners January 15, 2022 23:12
@zalgonoise zalgonoise changed the title Adding import references in examples/customsearch Examples: Adding import references in examples/customsearch Jan 15, 2022
@zalgonoise zalgonoise changed the title Examples: Adding import references in examples/customsearch fix: Adding import references in examples/customsearch Jan 15, 2022
@codyoss
Copy link
Member

codyoss commented Jan 18, 2022

Note we can add this, but is only sugar as the package name for that import is already customsearch

@codyoss codyoss enabled auto-merge (squash) January 18, 2022 15:47
@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2022
@codyoss codyoss merged commit 2f7c9e0 into googleapis:main Jan 18, 2022
@zalgonoise zalgonoise deleted the patch-1 branch January 25, 2022 19:07
@zalgonoise
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants