feat: add ECONNREFUSED to list of known errors for isAvailable() #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
AVaksman
approved these changes
Mar 3, 2020
JustinBeckwith
approved these changes
Mar 3, 2020
| @@ -203,6 +203,7 @@ export async function isAvailable() { | |||
| 'ENETUNREACH', | |||
| 'ENOENT', | |||
| 'ENOTFOUND', | |||
| 'ECONNREFUSED', | |||
There was a problem hiding this comment.
Is there a complete list of these somewhere? Or are there specific ones we're trying to avoid? Wondering if we just keep adding things to this list as people report them, or if there's a better way.
There was a problem hiding this comment.
I feel like I tried to dig into this once before without much success, can dig around again.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 3, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [3.5.0](https://www.github.com/googleapis/gcp-metadata/compare/v3.4.0...v3.5.0) (2020-03-03) ### Features * add ECONNREFUSED to list of known errors for isAvailable() ([#309](https://www.github.com/googleapis/gcp-metadata/issues/309)) ([17ff6ea](https://www.github.com/googleapis/gcp-metadata/commit/17ff6ea361d02de31463532d4ab4040bf6276e0b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ECONNREFUSEDto our list of known errors.see: #302, googleapis/nodejs-logging-winston#389