Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using errors.cause, simply return the error itself #56

Closed
jmuk opened this issue Oct 19, 2016 · 0 comments
Closed

stop using errors.cause, simply return the error itself #56

jmuk opened this issue Oct 19, 2016 · 0 comments
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@jmuk
Copy link
Contributor

jmuk commented Oct 19, 2016

Based on googleapis/google-cloud-node#1721 (comment):

There might not be a clear benefit of using 'Error' with cause property in NodeJS. This design originally came by respecting the design of gax-python, and that's good for Python because it fits with try...catch pattern.

gax-nodejs doesn't expect try...catch pattern at all, and we always use bare Error, thus it turns out this design does not fit to the actual usage quite well. Let's remove this.

@jmuk jmuk self-assigned this Oct 19, 2016
jmuk added a commit to jmuk/gax-nodejs that referenced this issue Oct 19, 2016
jmuk added a commit to jmuk/gax-nodejs that referenced this issue Oct 19, 2016
@jmuk jmuk closed this as completed in #57 Oct 19, 2016
jmuk added a commit that referenced this issue Oct 19, 2016
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants