Make ServiceApiSettings provider interfaces public #75

michaelbausor · 2016-04-25T20:26:50Z

Make ChannelProvider, ExecutorProvider and CredentialsProvider
interfaces public. This allows the ApiSettings object to be
constructed without instantiating the channel, executor or
credentials until they are required by the Api object.

Make ChannelProvider, ExecutorProvider and CredentialsProvider interfaces public. This allows the ApiSettings object to be constructed without instantiating the channel, executor or credentials until they are required by the Api object. Pre-push hook installed. Change-Id: I2b88beb112c24e8e35d5d58b4883bd4be0d15706

Pre-push hook installed. Change-Id: I6742fae6a8b1052ba1d5a9fc6bcebb90fa87cd7e

src/main/java/com/google/api/gax/core/ConnectionSettings.java

   */
-  interface CredentialsProvider {
+  public interface CredentialsProvider {


Moved interfaces to separate files Added shouldAutoClose parameter to ExecutorProvider Added OperationNotSupportedException to ExecutorProvider and ChannelProvider when a fixed executor/channel is accessed multiple times. Updated documentation Pre-push hook installed. Change-Id: Icb29408ad0854908932675723a2cc831d0111949

Removed exceptions not thrown Updated params in javadocs Fixed broken doc links Pre-push hook installed. Change-Id: I2a259ea65dd9a9094a67fdf8d78ad820abf3d7e2

michaelbausor · 2016-04-26T20:41:15Z

PTAL

src/main/java/com/google/api/gax/grpc/ExecutorProvider.java

+   *
+   * If the {@link ExecutorProvider} is configured to return a fixed
+   * {@link ScheduledExecutorService} object and to return shouldAutoClose as true, then after the
+   * first call to {@link #getExecutor}, subsequent calls should throw an {@link ExecutorProvider}.


Changed OperationNotSupportedException to IllegalStateException Fixed doc errors Pre-push hook installed. Change-Id: I33529e918b1e22ce643c03dd46f207a16adfe8ad

michaelbausor · 2016-04-27T19:03:58Z

PTAL
Regarding the tricksy situation you described above, I think that it is actually a valid (although very strange) use case. If the user wants to reuse a fixed channel (setting autoclose to false) but assigns different executors with autoclose set to true then that is fine. The case where they assign the same executor with autoclose true is already handling by the prevention of reusing a resource that will be autoclosed (either executor or channel).

Added unit tests Removed getOrBuild methods Set executorProvider in ServiceApiSettings constructor Pre-push hook installed. Change-Id: I193be2e6a6ad2e35b5f1def5182e19d9dc14ab29

src/main/java/com/google/api/gax/core/ConnectionSettings.java

   */
-  public Credentials getCredentials() throws IOException {
+  public Credentials getOrBuildCredentials() throws IOException {


Pre-push hook installed. Change-Id: Icd5d157d0d164f8eb2536778fbafbea7c5c546a2

Pre-push hook installed. Change-Id: I10039ae000dae902b30a9df43fdd5c1316191281

michaelbausor · 2016-04-28T20:22:35Z

PTAL

src/main/java/com/google/api/gax/grpc/ChannelProvider.java

+
+  /**
+   * Get the channel to be used to connect to the service. The first time this is called, if the
+   * channel does not already exist, it will be created.


Pre-push hook installed. Change-Id: I4ca6d7d72ad1941846bb9afcb68ee7d518317e3a

michaelbausor · 2016-04-28T21:42:08Z

PTAL

garrettjonesgoogle · 2016-04-28T21:43:52Z

LGTM

michaelbausor added 2 commits April 25, 2016 13:21

Use executor for channel

94ba6a1

Pre-push hook installed. Change-Id: I6742fae6a8b1052ba1d5a9fc6bcebb90fa87cd7e

garrettjonesgoogle reviewed Apr 25, 2016
View reviewed changes

src/main/java/com/google/api/gax/core/ConnectionSettings.java

*/

interface CredentialsProvider {

public interface CredentialsProvider {

This comment was marked as spam.

Sign in to view

michaelbausor added 2 commits April 26, 2016 13:25

Updated annotations

82ab4a2

Removed exceptions not thrown Updated params in javadocs Fixed broken doc links Pre-push hook installed. Change-Id: I2a259ea65dd9a9094a67fdf8d78ad820abf3d7e2

garrettjonesgoogle reviewed Apr 26, 2016
View reviewed changes

Changed exception type

0d24ef5

Changed OperationNotSupportedException to IllegalStateException Fixed doc errors Pre-push hook installed. Change-Id: I33529e918b1e22ce643c03dd46f207a16adfe8ad

Fixes and improvements

3169d16

Added unit tests Removed getOrBuild methods Set executorProvider in ServiceApiSettings constructor Pre-push hook installed. Change-Id: I193be2e6a6ad2e35b5f1def5182e19d9dc14ab29

michaelbausor force-pushed the master branch from 80a2f14 to 3169d16 Compare April 28, 2016 00:46

garrettjonesgoogle reviewed Apr 28, 2016
View reviewed changes

src/main/java/com/google/api/gax/core/ConnectionSettings.java

*/

public Credentials getCredentials() throws IOException {

public Credentials getOrBuildCredentials() throws IOException {

This comment was marked as spam.

Sign in to view

michaelbausor added 2 commits April 28, 2016 12:57

Renamed getChannel/getExecutor methods for providers

f0ea68c

Pre-push hook installed. Change-Id: Icd5d157d0d164f8eb2536778fbafbea7c5c546a2

Renamed getX methods in interfaces, removed throws IllegalState

1992d36

Pre-push hook installed. Change-Id: I10039ae000dae902b30a9df43fdd5c1316191281

garrettjonesgoogle reviewed Apr 28, 2016
View reviewed changes

Updated comments

8f34a6e

Pre-push hook installed. Change-Id: I4ca6d7d72ad1941846bb9afcb68ee7d518317e3a

michaelbausor merged commit 6ba722c into googleapis:master Apr 28, 2016

This was referenced May 4, 2016

ServiceApiSettings: Pass the provided executor to gRPC when creating the channel #73

Closed

Updating pubsub to match gax-java 0.0.12 googleapis/google-cloud-java#981

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make ServiceApiSettings provider interfaces public #75

Make ServiceApiSettings provider interfaces public #75

michaelbausor commented Apr 25, 2016

This comment was marked as spam.

michaelbausor commented Apr 26, 2016

This comment was marked as spam.

michaelbausor commented Apr 27, 2016

This comment was marked as spam.

michaelbausor commented Apr 28, 2016

This comment was marked as spam.

This comment was marked as spam.

michaelbausor commented Apr 28, 2016

garrettjonesgoogle commented Apr 28, 2016

Make ServiceApiSettings provider interfaces public #75

Make ServiceApiSettings provider interfaces public #75

Conversation

michaelbausor commented Apr 25, 2016

This comment was marked as spam.

michaelbausor commented Apr 26, 2016

This comment was marked as spam.

michaelbausor commented Apr 27, 2016

This comment was marked as spam.

michaelbausor commented Apr 28, 2016

This comment was marked as spam.

This comment was marked as spam.

michaelbausor commented Apr 28, 2016

garrettjonesgoogle commented Apr 28, 2016