This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Creating ApiCallableBuilder #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, converting ServiceApiSettings into ApiCallSettings, which ApiCallableBuilder extends.
|
Related PR: googleapis/google-cloud-java#716 |
|
LGTM. @anthmgoogle please take a look. |
| import java.util.concurrent.ScheduledExecutorService; | ||
| import java.util.concurrent.ScheduledThreadPoolExecutor; | ||
|
|
||
| // TODO(pongad): Don't close the channel if the user gives one to us |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM. |
garrettjonesgoogle
added a commit
that referenced
this pull request
Mar 8, 2016
Creating ApiCallableBuilder
bjwatson
pushed a commit
to googleapis/gapic-generator
that referenced
this pull request
Apr 20, 2016
Corresponding PR in gax-java: googleapis/gax-java#21 Change-Id: I21f902118c48eed94e086d09b7bdbfb0ffa4a791
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, converting ServiceApiSettings into ApiCallSettings, which
ApiCallableBuilder extends.