feat: relocate Netty Native Image configurations from java-core to gax #1638
Conversation
mpeddada1
force-pushed
the
relocate-netty
branch
from
6a0840e
to
9b863be
Compare
mpeddada1
changed the title
| import org.graalvm.nativeimage.hosted.RuntimeReflection; | ||
|
|
||
| /** Internal class offering helper methods for registering methods/classes for reflection. */ | ||
| public class NativeImageUtils { |
There was a problem hiding this comment.
Add annotation to indicate this is an internal API.
There was a problem hiding this comment.
Good call, added the internal API annotation.
| } | ||
|
|
||
| /** Registers all the classes under the specified package for reflection. */ | ||
| public static void registerPackageForReflection(FeatureAccess access, String packageName) { |
There was a problem hiding this comment.
Let's remove this as it's not used in gax.
There was a problem hiding this comment.
Good idea, removed this method.
| * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| package com.google.nativeimage; |
There was a problem hiding this comment.
To verify once again, @meltsufin @suztomo is this an acceptable package name? It looks like we have some classes under package com.google.api.gax.grpc and some under com.google in gax-grpc.
There was a problem hiding this comment.
I think it should actually go into "com.google.api.gax.grpc.nativeimage".
There was a problem hiding this comment.
Ah okay, corrected this. Thank you!
|
SonarCloud Quality Gate failed. |
mpeddada1
changed the title
This PR moves the Netty Native Image configurations from java-core to gax. Tested this out manually with Pub/Sub(includes gax+ gax-grpc as a dependency), Bigquery(includes only gax as a dependency) and Secretmanager(generated library). This PR is paired with googleapis/java-core#771