Add PHP Exception tests #951

michaelbausor · 2017-01-20T23:23:38Z

This PR looks like it changes a lot in the snip file, but it is only a minor restructuring that the git diff tool doesn't like for some reason. The existing tests are almost unchanged. Changes are:

Added exception case tests
Fixed bug in tests for methods without return values

codecov-io · 2017-01-20T23:27:21Z

Codecov Report

Merging #951 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #951      +/-   ##
============================================
+ Coverage     86.46%   86.47%   +<.01%     
  Complexity     3824     3824              
============================================
  Files           374      374              
  Lines         15252    15255       +3     
  Branches       1704     1704              
============================================
+ Hits          13188    13191       +3     
  Misses         1609     1609              
  Partials        455      455

Impacted Files	Coverage Δ	Complexity Δ
...ransformer/php/PhpGapicSurfaceTestTransformer.java	`100% <100%> (ø)`	`15 <1> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cadd53d...0bf7f36. Read the comment docs.

src/test/java/com/google/api/codegen/testdata/php_test_library.baseline

+        try {
+            $client->createShelf($shelf);
+            // If the $client method call did not throw, fail the test
+            $this->assertTrue(false);


src/main/resources/com/google/api/codegen/php/test.snip

+        {@simpleExceptionTestCase(test)}
+    @case "OperationOptionalArrayMethod"
+        {@lroTestCase(test)}
+        {@simpleExceptionTestCase(test)}


michaelbausor

PTAL

src/main/resources/com/google/api/codegen/php/test.snip

+        {@simpleExceptionTestCase(test)}
+    @case "OperationOptionalArrayMethod"
+        {@lroTestCase(test)}
+        {@simpleExceptionTestCase(test)}


src/test/java/com/google/api/codegen/testdata/php_test_library.baseline

+        try {
+            $client->createShelf($shelf);
+            // If the $client method call did not throw, fail the test
+            $this->assertTrue(false);


src/test/java/com/google/api/codegen/testdata/php_mock_service_library.baseline

@@ -23,15 +23,18 @@

 namespace Google\Tests\Example\Library\V1;

+use \Google\GAX\ApiException;


src/test/java/com/google/api/codegen/testdata/php_test_library.baseline

+            $this->assertEquals($status->details, $ex->getMessage());
+            $actualRequests = $grpcStub->getReceivedCalls();
+            $this->assertSame(1, count($actualRequests));
+            $actualFuncCall = $actualRequests[0]->getFuncCall();


michaelbausor · 2017-05-22T20:58:05Z

@shinfan Finally came back to this PR, sorry for the ridiculous delay.

shinfan

LGTM

* Fix JSON pretty print in Ruby sample (#1254) * Ruby: README Overhaul (feat. examples) (#1245) * go: use new metadata methods (#1262) Updates googleapis/google-cloud-go#624. metadata.FromContext and metdata.NewContext are replaced by metadata.{New,From}{Incoming,Outgoing}Context. Generated unit tests now verify that x-goog-api-client header is inserted. Additionally, clients now save a string slice containing x-goog-api-client header value instead of the value by itself. This is a small optimization so that we don't create a new slice every time. * Change media body from an object to a string (#1256) Samples fail before sending a request if the media body is an object. * Fix NONE auth Go sample (#1261) * Change Node.js unit test require. (#1264) * Ruby: Allow doc gapic generation to generate tests. (#1266) * Ruby: Remove aliasing from method samples and tests (#1253) * Ruby: Fix broken baselines from aliasing fix (#1269) * Remove unused code (#1270) * Python: README overhaul. (#1263) * Ruby: Update gemspec and add useful metadata files (#1258) * Ruby: Update gemspec and add useful metadata files * Specify HTTP client when constructing client (#1275) If a HTTP client is not passed to `build`, the Google API Python client will create a default one and attempt to authenticate it. This causes failures in environments where ADC auth is not available (Travis). In any case, it's not useful to access any auth code in the mock tests. This commit removes that possibility. * Fix JSON print in Ruby (#1274) It turns out that `to_h` is not a method available on every object returned by the samples at the moment. Also, there's some kind of decoding bug showing up in certain samples where the JSON module is unable to unparse the response. It's troublesome to have so much boilerplate just to pretty print. This commit removes the pretty calls in favor of the vanilla `to_json` method implemented by the base model class in the Ruby client. In the future, once the bugs w.r.t `pretty_generate` have been resolved, we can revert. * NodeJS: Update version index to support partial veneers (#1267) * NodeJS: Updates to package.json (#1268) * Migrate import disambiguation to Python MVVM (#1243) * Fix Node package.json (#1282) * go: use time.UnixNano instead of testutil.UIDSpace (#1279) Since generated code should be testable from api-client-staging repo, we want to reduce dependency on other cloud.google.com/go packages, especially internal ones. Clients will still depend on testutil for ProjID and TokenSource. This is OK, since they can be easily reimplemented in google-client-staging repo itself. * Update Java grpc metadata for new staging structure (#1265) * PHP: share credentials with operations client (#1283) * java: move CredentialProvider up to ClientSettings (#1251) This implements the client side changes to support googleapis/gax-java#305. * NodeJS: generate readme. (#1240) * NodeJS: Small additions to the package.json (#1289) * NodeJS: Use fileheader for copyright lines. (#1293) * NodeJS: Use correct casing for partial veneers (#1295) * NodeJS: Small readme fix from GCN reviews (#1294) * go: make longrunning methods use generated longrunning client (#1288) The cloud.google.com/go/longrunning package will need to change slightly to accomodate this change. xGoogHeader is now gone from the generated longrunnging types, as the header will be automatically inserted by LROClient itself. * NodeJS: Update partial veneer surface to add api documentation. (#1296) * NodeJS: Metadata updates. (#1298) * Readme: Update readme templates to add api summaries. (#1299) * Add PHP Exception tests (#951) * Add exception tests * Remove unnecessary checks in exception tests * Process markdown cloud links for PHP (#1091) * Process markdown cloud links for PHP * Restructure comment formatting * go: return error creating LRO client instead of panicking (#1300)

* merge master to Discogapic (#1304) * Fix JSON pretty print in Ruby sample (#1254) * Ruby: README Overhaul (feat. examples) (#1245) * go: use new metadata methods (#1262) Updates googleapis/google-cloud-go#624. metadata.FromContext and metdata.NewContext are replaced by metadata.{New,From}{Incoming,Outgoing}Context. Generated unit tests now verify that x-goog-api-client header is inserted. Additionally, clients now save a string slice containing x-goog-api-client header value instead of the value by itself. This is a small optimization so that we don't create a new slice every time. * Change media body from an object to a string (#1256) Samples fail before sending a request if the media body is an object. * Fix NONE auth Go sample (#1261) * Change Node.js unit test require. (#1264) * Ruby: Allow doc gapic generation to generate tests. (#1266) * Ruby: Remove aliasing from method samples and tests (#1253) * Ruby: Fix broken baselines from aliasing fix (#1269) * Remove unused code (#1270) * Python: README overhaul. (#1263) * Ruby: Update gemspec and add useful metadata files (#1258) * Ruby: Update gemspec and add useful metadata files * Specify HTTP client when constructing client (#1275) If a HTTP client is not passed to `build`, the Google API Python client will create a default one and attempt to authenticate it. This causes failures in environments where ADC auth is not available (Travis). In any case, it's not useful to access any auth code in the mock tests. This commit removes that possibility. * Fix JSON print in Ruby (#1274) It turns out that `to_h` is not a method available on every object returned by the samples at the moment. Also, there's some kind of decoding bug showing up in certain samples where the JSON module is unable to unparse the response. It's troublesome to have so much boilerplate just to pretty print. This commit removes the pretty calls in favor of the vanilla `to_json` method implemented by the base model class in the Ruby client. In the future, once the bugs w.r.t `pretty_generate` have been resolved, we can revert. * NodeJS: Update version index to support partial veneers (#1267) * NodeJS: Updates to package.json (#1268) * Migrate import disambiguation to Python MVVM (#1243) * Fix Node package.json (#1282) * go: use time.UnixNano instead of testutil.UIDSpace (#1279) Since generated code should be testable from api-client-staging repo, we want to reduce dependency on other cloud.google.com/go packages, especially internal ones. Clients will still depend on testutil for ProjID and TokenSource. This is OK, since they can be easily reimplemented in google-client-staging repo itself. * Update Java grpc metadata for new staging structure (#1265) * PHP: share credentials with operations client (#1283) * java: move CredentialProvider up to ClientSettings (#1251) This implements the client side changes to support googleapis/gax-java#305. * NodeJS: generate readme. (#1240) * NodeJS: Small additions to the package.json (#1289) * NodeJS: Use fileheader for copyright lines. (#1293) * NodeJS: Use correct casing for partial veneers (#1295) * NodeJS: Small readme fix from GCN reviews (#1294) * go: make longrunning methods use generated longrunning client (#1288) The cloud.google.com/go/longrunning package will need to change slightly to accomodate this change. xGoogHeader is now gone from the generated longrunnging types, as the header will be automatically inserted by LROClient itself. * NodeJS: Update partial veneer surface to add api documentation. (#1296) * NodeJS: Metadata updates. (#1298) * Readme: Update readme templates to add api summaries. (#1299) * Add PHP Exception tests (#951) * Add exception tests * Remove unnecessary checks in exception tests * Process markdown cloud links for PHP (#1091) * Process markdown cloud links for PHP * Restructure comment formatting * go: return error creating LRO client instead of panicking (#1300) * fails b/c Node.empty() uses null params * one test passes * all current tests pass * tests for Node parent() * Test * removed Method.empty(): * reordering methods for convention * made Node.from(Node, path) methods package private * removed path() from Document, Schema, and Method * removed static constructors with empty parent node

michaelbausor added 3 commits January 20, 2017 14:16

Add exception tests

ea215b9

Update exception tests

3c84f3f

Fix bug in tests without return value

2b3cc9d

michaelbausor assigned shinfan and garrettjonesgoogle Jan 20, 2017

shinfan reviewed Jan 21, 2017

View reviewed changes

michaelbausor added 3 commits February 21, 2017 09:56

Merge branch 'master' into exception-tests

2cfaab9

Address PR comments

ddf4e82

Address PR comments

e886d5c

michaelbausor commented Feb 21, 2017

View reviewed changes

shinfan reviewed Feb 27, 2017

View reviewed changes

michaelbausor added 2 commits May 22, 2017 12:44

Merge branch 'master' into exception-tests

c6863cf

Remove unnecessary checks in exception tests

0bf7f36

shinfan approved these changes May 25, 2017

View reviewed changes

michaelbausor merged commit 9316dc5 into googleapis:master May 26, 2017

michaelbausor deleted the exception-tests branch May 26, 2017 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PHP Exception tests #951

Add PHP Exception tests #951

michaelbausor commented Jan 20, 2017

codecov-io commented Jan 20, 2017 •

edited

Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

michaelbausor left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

michaelbausor commented May 22, 2017

shinfan left a comment

		@@ -23,15 +23,18 @@

		namespace Google\Tests\Example\Library\V1;

		use \Google\GAX\ApiException;

Add PHP Exception tests #951

Add PHP Exception tests #951

Conversation

michaelbausor commented Jan 20, 2017

codecov-io commented Jan 20, 2017 • edited Loading

Codecov Report

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

michaelbausor left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

michaelbausor commented May 22, 2017

shinfan left a comment

Choose a reason for hiding this comment

codecov-io commented Jan 20, 2017 •

edited

Loading