Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Modify NodeJS codegen to fit with gcloud-node design. #392

Merged
merged 4 commits into from
Aug 23, 2016

Commits on Aug 18, 2016

  1. Modify NodeJS codegen to fit with gcloud-node design.

    - The new style exports a function instead of the class. The
      exported function will take the auth context as a parameter
      and returns builder function.
    - Files will be under a sub directory with versioned name,
      so that it can be exposed as a sub package of the API package.
    - A few misc changes and style changes made to pass lint
      checker in gcloud.
    jmuk committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    f4b2b41 View commit details
    Browse the repository at this point in the history
  2. Rebase and fix test baselines.

    jmuk committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    4bfde02 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2016

  1. Fix doc comments.

    - constructor parameters are not actually useful now. They are
      parameters to the builder function actually, so I moved there.
    - build() is not a function, now it's a class. This way, JSDoc
      can generate documentations for its methods (like builder function).
    - add an example clause in the constructor doc comments, so that
      documentation says the details of how to create an instance of
      the API client.
    jmuk committed Aug 22, 2016
    Configuration menu
    Copy the full SHA
    0e3ed57 View commit details
    Browse the repository at this point in the history
  2. Modify comments.

    jmuk committed Aug 22, 2016
    Configuration menu
    Copy the full SHA
    c6f9f37 View commit details
    Browse the repository at this point in the history