Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Revert "java: move CredentialProvider up to ClientSettings (#1251)" #1317

Merged
merged 1 commit into from
Jun 1, 2017
Merged

Conversation

pongad
Copy link
Contributor

@pongad pongad commented Jun 1, 2017

This reverts commit 2da784d.

@garrettjonesgoogle
Copy link
Member

LGTM

@pongad pongad merged commit 7ed21da into googleapis:master Jun 1, 2017
@pongad pongad deleted the rev branch June 1, 2017 21:58
@codecov-io
Copy link

Codecov Report

Merging #1317 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1317      +/-   ##
============================================
- Coverage     86.48%   86.47%   -0.01%     
  Complexity     3836     3836              
============================================
  Files           378      378              
  Lines         15328    15323       -5     
  Branches       1694     1694              
============================================
- Hits          13256    13251       -5     
  Misses         1622     1622              
  Partials        450      450
Impacted Files Coverage Δ Complexity Δ
.../transformer/java/JavaGapicSurfaceTransformer.java 98.11% <100%> (-0.03%) 43 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb472d3...15685e7. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants