-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Google Ads Docker file paths #165
Update Google Ads Docker file paths #165
Conversation
So the file path and require changes will be made.
This allows files to be moved to directories that already exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance of some echo
calls to print what's happening?
Make some suggestions in the code. I don't know what you are looking for. |
OK, just a sec, I'll open suggestions |
The docker image calls protoc with all three plugins: 1) protobuf, 2) grpc, and 3) gapic. The gapic generator can't alter the output of the other two plugins, so this PR updates the docker image to alter the output for all three protoc plugins. For example, the protobuf plugin will take the proto file Then, the grpc plugin takes the same proto file The generated gapic files require both the generated protobuf and grpc files, and those requires are also updated. Lastly, the files generated by the protobuf plugin also reference the original proto file. It has code similar to the following: add_file("google/ads/googleads/v1/services/campaign_service.proto", :syntax => :proto3) do
# add messages
end The file path of original proto file referenced in the ruby code is not changed, even though the generated ruby files are. |
Update the Google Ads docker image to change the file paths of the files generated by the protobuf and grpc plugins.