Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade rules_python to 0.26.0 #1825

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 26, 2023

Fixes #1824 🦕

@parthea parthea requested a review from a team as a code owner October 26, 2023 12:02
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 26, 2023
@ohmayr ohmayr merged commit 5d66387 into main Oct 26, 2023
53 checks passed
@ohmayr ohmayr deleted the upgrade-rules-python-0-26-0 branch October 26, 2023 15:04
mergify bot pushed a commit to tensorflow/tflite-micro that referenced this pull request Aug 12, 2024
Before, when trying to use to build the project using Bazel, this would result in multiple occurrence of this error:
`AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?`

This error is due to `rules_python` being too old. While building with Python3.12 still result in an error, the new one clearly indicate is mismatch of the TensorFlow version.

Very similar/related: googleapis/gapic-generator-python#1825

BUG=tensorflow/tensorflow#73174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bazel build fails with AttributeError module 'pkgutil' has no attribute 'ImpImporter'
2 participants