Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #942 - use req.ip in express and koa plugin #944

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Conversation

sh
Copy link
Contributor

@sh sh commented Dec 17, 2018

fix for #942 :)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 17, 2018
@kjin kjin self-requested a review December 17, 2018 17:48
@sh
Copy link
Contributor Author

sh commented Dec 17, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 17, 2018
src/plugins/plugin-koa.ts Outdated Show resolved Hide resolved
@kjin kjin merged commit 126bc75 into googleapis:master Dec 17, 2018
@SifouElYasLakhHa
Copy link

I signed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants