-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use well-known format for propagating trace context thru grpc #814
Conversation
cc/ @rakyll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the commit message should clearly indicate that it is a breaking change.
src/plugins/plugin-grpc.ts
Outdated
* @param span The span that contains the trace context to add as a metadata | ||
* entry. | ||
*/ | ||
function setTraceContextFromString(metadata: Metadata, span: Span): void { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Please make sure that the commit - at landing time - includes 'BREAKING CHANGE:' prefix in the body as per conventionalcommits.org. |
BREAKING CHANGE: The change in distributed trace context propagation across gRPC is not backwards-compatible. In other words, distributed tracing will not work between two Node instances communicating using gRPC with v2 and v3 of the Trace Agent, respectively.
Trace context can now be propagated thru gRPC with the
'grpc-trace-bin'
key, and a binary-encoded value.