Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup todos #395

Merged
merged 1 commit into from
Feb 24, 2017
Merged

cleanup todos #395

merged 1 commit into from
Feb 24, 2017

Conversation

matthewloring
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 18, 2017
@matthewloring matthewloring changed the title Simplify redis + cleanup todos cleanup todos Feb 18, 2017
@matthewloring
Copy link
Contributor Author

PTAL.

@matthewloring matthewloring modified the milestone: Beta Feb 20, 2017
kjin
kjin reviewed Feb 21, 2017
View reviewed changes
src/trace-plugin-interface.js
@@ -102,7 +102,6 @@ RootSpan.prototype.getTraceContext = function() {
/**
* PluginAPI constructor. Don't call directly - a plugin object will be passed to
* plugin themselves
* TODO(kjin): Should be called something else

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

kjin
kjin reviewed Feb 21, 2017
View reviewed changes
src/plugins/plugin-redis.js
var span = setupSpan(api, cmd.command, cmd.args, 0);
if (!span) {
return internal_send_command.call(this, cmd, args, cb);
return internal_send_command.call(this, cmd);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

kjin
kjin reviewed Feb 21, 2017
View reviewed changes
test/test-trace-agent.js
@@ -34,17 +34,13 @@ var assert = require('assert');
var config = require('../config.js');
var file = require('../src/trace-agent.js');
var SpanData = require('../src/span-data.js');
// TODO: This line will silently fail if a logger is not supplied as
// the second argument.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@matthewloring matthewloring merged commit f5662e0 into googleapis:master Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjin kjin kjin approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewloring @kjin @googlebot