Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stack trace to service network errors #394

Merged
merged 1 commit into from
Feb 22, 2017
Merged

Add stack trace to service network errors #394

merged 1 commit into from
Feb 22, 2017

Conversation

matthewloring
Copy link
Contributor

Fixes #349

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 18, 2017
@matthewloring
Copy link
Contributor Author

PTAL.

@matthewloring matthewloring added this to the Beta milestone Feb 20, 2017
kjin
kjin suggested changes Feb 21, 2017
View reviewed changes
src/trace-writer.js Outdated
@@ -256,7 +256,7 @@ TraceWriter.prototype.publish_ = function(projectId, json) {
}, function(err, response, body) {
if (err) {
that.logger_.error('TraceWriter: error: ',
(response && response.statusCode) || '', err);
(response && response.statusCode) || '' + '\n' + err.message + '\n' + err.stack);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@matthewloring matthewloring merged commit 6a307d1 into googleapis:master Feb 22, 2017
@matthewloring matthewloring deleted the errors branch February 22, 2017 17:19
@matthewloring matthewloring mentioned this pull request Feb 22, 2017
Closed
ofrobots
ofrobots reviewed Feb 22, 2017
View reviewed changes
src/trace-writer.js
@@ -256,7 +256,7 @@ TraceWriter.prototype.publish_ = function(projectId, json) {
}, function(err, response, body) {
if (err) {
that.logger_.error('TraceWriter: error: ',
(response && response.statusCode) || '', err);
((response && response.statusCode) || '') + '\n' + err.message + '\n' + err.stack);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrobots ofrobots ofrobots left review comments

@kjin kjin kjin approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewloring @ofrobots @kjin @googlebot