Support Koa tracing through the plugin API #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
DominicKramer
force-pushed
the
plugin/support-koa
branch
from
2914af3
to
7c6dfd3
Compare
|
PTAL |
DominicKramer
force-pushed
the
plugin/support-koa
branch
2 times, most recently
from
82c2b80
to
379416a
Compare
matthewloring
approved these changes
Feb 15, 2017
src/plugins/plugin-koa.js
Outdated
| } | ||
| //else { | ||
| // TODO: Determine if this is still needed | ||
| // agent.logger.warn('koa: Attempted to generate trace context for nullSpan'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
DominicKramer
force-pushed
the
plugin/support-koa
branch
from
fc9c343
to
3463b39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.