Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time to tracewriter timeout test to reduce flake #275

Merged
merged 1 commit into from
Jul 6, 2016
Merged

Add time to tracewriter timeout test to reduce flake #275

merged 1 commit into from
Jul 6, 2016

Conversation

matthewloring
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 6, 2016
@matthewloring
Copy link
Contributor Author

@ofrobots @cristiancavalli PTAL.

@cristiancavalli
Copy link
Contributor

@matthewloring This LGTM and the test passes on my machine with the proposed change. Not sure if the travis-ci is flaking though

@matthewloring
Copy link
Contributor Author

The failure is pending the fix in #273. It is unrelated to this change.

@cristiancavalli
Copy link
Contributor

LGTM given test dependencies

@matthewloring matthewloring merged commit 7d536ba into googleapis:master Jul 6, 2016
@matthewloring matthewloring deleted the trace-writer-flake branch July 6, 2016 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewloring @cristiancavalli @googlebot