Experimental tracing hooks for koa #192
Conversation
googlebot
added
the
cla: yes
|
@ofrobots I need to experiment more to make sure we're not losing context for DB operations made inside koa but the current state of the hooks is capable of tracing incoming requests. PTAL. |
| }; | ||
| } | ||
|
|
||
| function *middleware(next) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@ofrobots Ready for another look (tests passing now) |
| @@ -35,7 +35,7 @@ function run { | |||
| C="$(npm bin)/istanbul cover --dir ./coverage/${counter}" | |||
| ((counter++)) | |||
| fi | |||
| ($C "$(npm bin)/_mocha" -- $* --timeout 4000 --R spec) || exit 1 | |||
| (node --harmony $C "$(npm bin)/_mocha" -- $* --timeout 4000 --R spec) || exit 1 | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@ofrobots This should be working without the harmony flag. PTAL. |
| if [[ ! $(node --version) =~ v0\.12\..* || ! "${test}" =~ .*trace\-koa\.js ]] | ||
| then | ||
| run "${test}" | ||
| fi |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM as experimental support. |
Fixes #191
Fixes #191