-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental tracing hooks for koa #192
Conversation
@ofrobots I need to experiment more to make sure we're not losing context for DB operations made inside koa but the current state of the hooks is capable of tracing incoming requests. PTAL. |
}; | ||
} | ||
|
||
function *middleware(next) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@ofrobots Ready for another look (tests passing now) |
@@ -35,7 +35,7 @@ function run { | |||
C="$(npm bin)/istanbul cover --dir ./coverage/${counter}" | |||
((counter++)) | |||
fi | |||
($C "$(npm bin)/_mocha" -- $* --timeout 4000 --R spec) || exit 1 | |||
(node --harmony $C "$(npm bin)/_mocha" -- $* --timeout 4000 --R spec) || exit 1 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@ofrobots This should be working without the harmony flag. PTAL. |
if [[ ! $(node --version) =~ v0\.12\..* || ! "${test}" =~ .*trace\-koa\.js ]] | ||
then | ||
run "${test}" | ||
fi |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
LGTM as experimental support. |
Fixes #191
Fixes #191