Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request is loaded by our dependencies before we can patch setImmediate #182

Closed
matthewloring opened this issue Nov 26, 2015 · 2 comments
Closed

request is loaded by our dependencies before we can patch setImmediate #182

matthewloring opened this issue Nov 26, 2015 · 2 comments
Assignees
@matthewloring
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. 🚨 This issue needs some love. triage me I really want to be triaged.
Milestone
0.3.0

Comments

@matthewloring
Copy link
Contributor

No description provided.

@matthewloring matthewloring assigned ofrobots and unassigned ofrobots Nov 26, 2015
@ofrobots ofrobots changed the title Http is loaded by our dependencies before we can patch it request is loaded by our dependencies before we can patch it Nov 26, 2015
@matthewloring
Copy link
Contributor Author

We do not currently patch request. Isn't it the underlying http require done by request that is problematic?

@ofrobots ofrobots changed the title request is loaded by our dependencies before we can patch it request is loaded by our dependencies before we can patch setImmediate Nov 28, 2015
@ofrobots
Copy link
Contributor

Updated the title to make it more accurate. The problem is that we need to patch setImmediate (indirectly through CLS) before request is loaded. request caches the value of setImmediate.

ofrobots added a commit to ofrobots/cloud-trace-nodejs that referenced this issue Nov 28, 2015
@ofrobots
load cls before all else
3a39e09 
This ensures that the code async APIs get patched befored anything use-space can
get loaded and interfere with tracing. This is a problem with `request` in
particular as it caches setImmediate.

Fixes: googleapis#182
@ofrobots ofrobots mentioned this issue Nov 28, 2015
Closed
@matthewloring matthewloring added this to the 0.3.0 milestone Nov 30, 2015
@matthewloring matthewloring mentioned this issue Dec 1, 2015
Merged
@google-cloud-label-sync google-cloud-label-sync bot added the api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. label Jan 31, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewloring matthewloring

Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
3 participants
@ofrobots @matthewloring @yoshi-automation