Remove agent isRunning/trace isActive (#368)

PR-URL: #368

index.js

@@ -95,11 +95,7 @@ var initConfig = function(projectConfig) {
  */
 var publicAgent = {
   isActive: function() {
-    // TODO: The use of agent.isRunning() is only needed because the
-    //       _private() function is used in testing.
-    //       Remove the _private() function so that agent.isRunning()
-    //       can be removed.
-    return agent !== phantomTraceAgent && agent.isRunning();
+    return agent !== phantomTraceAgent;
   },
 
   startSpan: function(name, labels) {
@@ -248,18 +244,13 @@ function start(config) {
   return publicAgent;
 }
 
-function isActive() {
-  return publicAgent.isActive();
-}
-
 function get() {
   return publicAgent.get();
 }
 
 global._google_trace_agent = publicAgent;
 module.exports = {
   start: start,
-  isActive: isActive,
   get: get
 };
 

src/trace-agent.js

@@ -36,7 +36,6 @@ var traceAgent;
 function TraceAgent(config, logger) {
   this.config_ = config;
   this.logger = logger;
-  this.running = true;
 
   hooks.activate(this);
   pluginLoader.activate(this);
@@ -61,18 +60,10 @@ function TraceAgent(config, logger) {
   logger.info('trace agent activated');
 }
 
-TraceAgent.prototype.isRunning = function() {
-  return this.running;
-};
-
 /**
  * Halts this agent and unpatches any patched modules.
  */
 TraceAgent.prototype.stop = function() {
-  // TODO: This property is only needed because of the way the tests are
-  //       implemented.  Change the tests so that this property is not
-  //       needed.
-  this.running = false;
   hooks.deactivate();
   pluginLoader.deactivate();
   cls.destroyNamespace();

test/fixtures/preloaded-agent.js

@@ -18,6 +18,6 @@
 var assert = require('assert');
 var agent = require('../../');
 
-assert(agent.isActive());
+assert(agent.get().isActive());
 agent.get().stop();
 console.log('Preload test passed.');