Skip to content

Commit

Permalink
Cleanup todos
Browse files Browse the repository at this point in the history
  • Loading branch information
Matt Loring committed Jan 13, 2016
1 parent 903cec6 commit 67f6c67
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 12 deletions.
5 changes: 2 additions & 3 deletions lib/cls.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,9 @@ module.exports = {
getNamespace: getNamespace,

getRootContext: function getRootContext() {
// TODO: First getNamespace check is necessary in case any
// First getNamespace check is necessary in case any
// patched closures escaped before the agent was stopped and the
// namespace was destroyed. There should be a cleaner way to
// avoid this (only collect traces once we have a project num)
// namespace was destroyed.
if (getNamespace() && getNamespace().get('root')) {
return getNamespace().get('root');
}
Expand Down
3 changes: 0 additions & 3 deletions lib/trace-labels.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@

'use strict';

// TODO(ofrobots): replace this file with the protobuf
// c.f. trace/proto/span_details.proto

/**
* Well-known trace span label values.
*/
Expand Down
2 changes: 0 additions & 2 deletions lib/trace-span.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

'use strict';

// TODO(ofrobots): replace this file with the protobuf

/**
* Creates a trace span object.
* @constructor
Expand Down
2 changes: 0 additions & 2 deletions lib/trace-writer.js
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,6 @@ TraceWriter.prototype.publish_ = function(projectId, json) {
headers: headers
}, function(err, response, body) {
if (err) {
// TODO(ofrobots): If we failed to publish due to a permanent error, stop
// the agent.
that.logger_.error('TraceWriter: error: ',
(response && response.statusCode) || '', err);
} else {
Expand Down
2 changes: 0 additions & 2 deletions lib/trace.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

'use strict';

// TODO(ofrobots): replace this file with the protobuf

/**
* Creates a trace object.
* @constructor
Expand Down

0 comments on commit 67f6c67

Please sign in to comment.