Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update go installation method #862

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Conversation

psx95
Copy link
Contributor

@psx95 psx95 commented Dec 12, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

PR Description

Fixes the go installation method, following steps from https://go.dev/doc/install.

Steps currently followed attempted to install 2 different versions of the Go programming language, which no longer seem to work -

  • Following instructions to manage multiple installations of the Go programming language, does not work anymore. (Tested on a linux based VM).

Fixes #863 🦕

@psx95 psx95 requested review from a team as code owners December 12, 2022 20:52
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. labels Dec 12, 2022
@psx95 psx95 requested a review from aabmass December 12, 2022 20:52
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 68.87% // Head: 68.87% // No change to project coverage 👍

Coverage data is based on head (f32c1c8) compared to base (3dd65e9).
Patch has no changes to coverable lines.

❗ Current head f32c1c8 differs from pull request most recent head 91dcf12. Consider uploading reports for the commit 91dcf12 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #862   +/-   ##
=======================================
  Coverage   68.87%   68.87%           
=======================================
  Files           7        7           
  Lines        1253     1253           
  Branches       58       58           
=======================================
  Hits          863      863           
  Misses        389      389           
  Partials        1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@psx95 psx95 changed the title Update go version fix: update go installation method Dec 12, 2022
@psx95 psx95 force-pushed the fix-ci-test branch 3 times, most recently from f32c1c8 to cb740a2 Compare December 12, 2022 21:45
@psx95 psx95 merged commit 07f69a7 into googleapis:main Dec 13, 2022
@psx95 psx95 deleted the fix-ci-test branch December 13, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken CI builds
2 participants