Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: library should be released as 4.2.0 #833

Merged
merged 1 commit into from
May 13, 2022

Conversation

amchiclet
Copy link
Contributor

@amchiclet amchiclet commented May 11, 2022

I think this previous PR should have been a feature and the minor version should be bumped up as a result.

Creating an empty PR here with "feat:" in the title, so Release Please picks it up and the next release would be a minor version update.

@product-auto-label product-auto-label bot added size: u Pull request is empty. api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. labels May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #833 (28f15a9) into main (fe0f1cc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #833   +/-   ##
=======================================
  Coverage   69.15%   69.15%           
=======================================
  Files           7        7           
  Lines        1248     1248           
  Branches       58       58           
=======================================
  Hits          863      863           
  Misses        384      384           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c52cdea...28f15a9. Read the comment docs.

@amchiclet amchiclet marked this pull request as ready for review May 11, 2022 20:34
@amchiclet amchiclet changed the title fix: library should released as 4.2.0 feat: library should released as 4.2.0 May 11, 2022
@amchiclet amchiclet changed the title feat: library should released as 4.2.0 feat: library should be released as 4.2.0 May 11, 2022
@nolanmar511 nolanmar511 merged commit 8d722aa into googleapis:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. size: u Pull request is empty.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants