Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lazily init logging #801

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Conversation

jonahsnider
Copy link
Contributor

Fixes #800

@jonahsnider jonahsnider requested review from a team as code owners February 6, 2022 23:04
@product-auto-label product-auto-label bot added the api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. label Feb 6, 2022
@jonahsnider jonahsnider changed the title Lazily init logging fix: lazily init logging Feb 6, 2022
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 3, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c057bf1) 69.50% compared to head (fcac62d) 69.65%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/logger.ts 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #801      +/-   ##
==========================================
+ Coverage   69.50%   69.65%   +0.14%     
==========================================
  Files           7        7              
  Lines        1256     1262       +6     
  Branches       48       49       +1     
==========================================
+ Hits          873      879       +6     
  Misses        382      382              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@punya punya added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@punya punya added the automerge Merge the pull request once unit tests and other checks pass. label Sep 9, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 9, 2022
@punya punya added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2022
@aabmass aabmass added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
@aabmass aabmass added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
@aabmass aabmass enabled auto-merge (squash) February 2, 2024 21:10
@aabmass aabmass added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Just importing this package in a non-GCP environment logs errors to console
4 participants