fix: relax service name requirements to allow starting with numbers #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
nolanmar511
approved these changes
May 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #828 +/- ##
=======================================
Coverage 69.15% 69.15%
=======================================
Files 7 7
Lines 1248 1248
Branches 58 58
=======================================
Hits 863 863
Misses 384 384
Partials 1 1
Continue to review full report at Codecov.
|
This was referenced May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, profiling agents can be run with App Engine applications whose service names start with number.