This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Adjust api breakpoint if resolved in another line #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change api type breakpoint location line number if the breakpoint was originally set to a line with only comments. The new line that breakpoint set to will be actual paused line in code.
gaofanmichael
requested review from
ofrobots,
matthewloring,
kjin and
DominicKramer
googlebot
added
the
cla: yes
jmdobry
added
in progress
and removed
cla: yes
src/agent/state.ts
Outdated
| return { | ||
| location: {line: this.state_.frame(0).sourceLine()} as |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/agent/v8debugapi.ts
Outdated
| @@ -612,6 +612,11 @@ export function create( | |||
| // TODO: Address the case where `breakpoint.expression` is `undefined`. | |||
| const captured = state.capture( | |||
| execState, breakpoint.expressions as string[], config, v8); | |||
| if (breakpoint.location !== undefined && | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test-v8debugapi.ts
Outdated
| @@ -500,6 +500,29 @@ describe('v8debugapi', function() { | |||
|
|
|||
| }); | |||
|
|
|||
| it('should resolve correct breakpoint line number', function(done) { | |||
| // clone a clean breakpointInFoo | |||
| // TODO: Have this actually implement Breakpoint | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test-v8debugapi.ts
Outdated
| @@ -500,6 +500,29 @@ describe('v8debugapi', function() { | |||
|
|
|||
| }); | |||
|
|
|||
| it('should resolve correct breakpoint line number', function(done) { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
googlebot
added
the
cla: yes
matthewloring
approved these changes
Sep 19, 2017
src/agent/v8debugapi.ts
Outdated
| @@ -612,6 +612,8 @@ export function create( | |||
| // TODO: Address the case where `breakpoint.expression` is `undefined`. | |||
| const captured = state.capture( | |||
| execState, breakpoint.expressions as string[], config, v8); | |||
| if (breakpoint.location && captured.location && captured.location.line) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change api type breakpoint location line number if the breakpoint was
originally set to a line with only comments. The new line that
breakpoint set to will be actual paused line in code.