Use mocha for end-to-end tests #212

kjin · 2016-12-23T23:46:43Z

Turned test-breakpoints.js and test-log-throttling.js into mocha tests in a new file test-e2e.js. This involved splitting off the debuggee into a separate file (fib.js).

Changes to the tests themselves are:

Spawned children now each have their own log object in the test, and each log is individually checked (whereas before, there was a single object that contained logs from all children).
The log throttling test now also spawns three children (instead of one), since it uses common initialization logic.

test/fixtures/fib.js

+      process.send([errorMessage]);
+    }
+  };
+  sendErrorIfNotOk(debug.private_, 'debuglet has initialized');


test/e2e/test-e2e.js

+  });
+};
+
+describe('@google-cloud/debug end-to-end behavior (allow 60s)', function () {


test/fixtures/fib.js

+  sendErrorIfNotOk(debuggee.id, 'debuggee should have registered');
+  if (ok) {
+    // The parent process needs to know the debuggeeId and project.
+    process.send(['', debuggee.id, debuggee.project]);


test/e2e/test-e2e.js

+          assert.equal(debuggeeId, a[1]);
+          assert.equal(projectId, a[2]);
+          if (debuggeeId !== a[1] || projectId !== a[2]) {
+            reject(new Error('Child debuggee ID and/or project ID' +


test/e2e/test-e2e.js

+
+  afterEach(function() {
+    children.forEach(function (child) {
+      child.process.kill();


matthewloring

LGTM once things are passing for 0.12

kjin · 2016-12-29T00:01:57Z

Still fixing tests - since E2E tests fail.

kjin · 2017-01-04T22:47:01Z

E2E tests pass: https://travis-ci.org/GoogleCloudPlatform/cloud-debug-nodejs/builds/189010678

test/standalone/test-capture-time.js

@@ -0,0 +1,109 @@
+// /**


kjin added 4 commits December 23, 2016 15:36

Converted test-breakpoints to mocha test

b6ead94

Turned e2e tests into mocha tests

69db850

Modify e2e test to use promisifyAll

4a4485b

No longer making functions inside a loop

92129df

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 23, 2016

Updated e2e runners and removed package.json

a827a65

kjin requested review from ofrobots, matthewloring, cristiancavalli and DominicKramer December 24, 2016 00:48

matthewloring suggested changes Dec 24, 2016

View reviewed changes

Addressed comments

1d81a62

kjin force-pushed the mocha-e3e branch from 43c743a to c908392 Compare December 27, 2016 23:02

matthewloring approved these changes Dec 28, 2016

View reviewed changes

kjin force-pushed the mocha-e3e branch 2 times, most recently from a22178c to de9172a Compare December 28, 2016 22:37

kjin force-pushed the mocha-e3e branch from de9172a to 6b7281a Compare January 3, 2017 19:11

kjin added 3 commits January 4, 2017 13:50

Fix for v0.12

6fe6df1

set breakpoint check interval to 5s

fca93d9

Removed cd - from system test runner

a264d94

kjin force-pushed the mocha-e3e branch from 6b7281a to a264d94 Compare January 4, 2017 22:46

Corrected run-test.sh

2ac939f

kjin force-pushed the mocha-e3e branch from 649e162 to 2ac939f Compare January 4, 2017 22:56

Make breakpoint fetch happen every sec

3d65bef

ofrobots reviewed Jan 4, 2017

View reviewed changes

kjin added 2 commits January 4, 2017 15:51

uncommented a whole file!

bb5a69b

removed it altogether

1c0de81

kjin merged commit a28d719 into googleapis:master Jan 5, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use mocha for end-to-end tests #212

Use mocha for end-to-end tests #212

kjin commented Dec 23, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

matthewloring left a comment

kjin commented Dec 29, 2016

kjin commented Jan 4, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Use mocha for end-to-end tests #212

Use mocha for end-to-end tests #212

Conversation

kjin commented Dec 23, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

matthewloring left a comment

Choose a reason for hiding this comment

kjin commented Dec 29, 2016

kjin commented Jan 4, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.