Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

feat: improve debuggee ids #1097

Merged
merged 3 commits into from
Jul 26, 2022
Merged

feat: improve debuggee ids #1097

merged 3 commits into from
Jul 26, 2022

Conversation

mctavish
Copy link
Contributor

@mctavish mctavish commented Jul 25, 2022

Debuggee ids are now of the form: d-********

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1096 🦕

Debuggee ids are now of the form: d-********
@mctavish mctavish requested review from a team as code owners July 25, 2022 20:38
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. labels Jul 25, 2022
@mctavish mctavish requested a review from jasonborg July 25, 2022 20:47
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1097 (e4d0696) into main (98c7433) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1097      +/-   ##
==========================================
- Coverage   65.77%   65.33%   -0.44%     
==========================================
  Files          21       21              
  Lines        1750     1751       +1     
  Branches      352      352              
==========================================
- Hits         1151     1144       -7     
- Misses        512      515       +3     
- Partials       87       92       +5     
Impacted Files Coverage Δ
src/agent/firebase-controller.ts 68.49% <100.00%> (+0.43%) ⬆️
src/agent/util/utils.ts 92.59% <0.00%> (-3.71%) ⬇️
src/agent/state/inspector-state.ts 87.50% <0.00%> (-1.86%) ⬇️
src/agent/v8/inspector-debugapi.ts 84.16% <0.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c7433...e4d0696. Read the comment docs.

@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2022
src/agent/firebase-controller.ts Show resolved Hide resolved
src/agent/firebase-controller.ts Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 26, 2022
@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 26, 2022
@mctavish mctavish merged commit 267a4bd into googleapis:main Jul 26, 2022
@mctavish mctavish deleted the debuggeeid branch July 26, 2022 17:02
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 26, 2022
🤖 I have created a release *beep* *boop*
---


## [7.1.0](v7.0.0...v7.1.0) (2022-07-26)


### Features

* improve debuggee ids ([#1097](#1097)) ([267a4bd](267a4bd))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@mctavish mctavish restored the debuggeeid branch August 8, 2022 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch firebase-backend debuggee id formats to d-********
2 participants