fix(AIP-136): handle LRO response names #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common lint for response message name matching needs to better handle LRO Methods which have their response message encoded in the
google.longrunning.operation_infoannotation.This fixes the common lint to properly compare the response_type name instead of the rpc return type in the LRO case, as well as the AIP-136 implementation to warn on the proper spot.
Internal bug b/342434484
cc: @liveFreeOrCode just an fyi - the helper we used had a little bug in it that would let it fall through to the finding logic on valid RPCs using LRO. I should've asked for LRO case in the tests! my bad