Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependency: xmltodict #524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

gdrosos
Copy link

@gdrosos gdrosos commented Aug 27, 2023

Summary

Hello @christopherseeley, @msaniscalchi,

I hope you're doing well! I've just opened this pull request that proposes the removal of the unused dependency xmltodict from the setup.py configuration file. It's part of an ongoing research endeavor focusing on the identification and elimination of code bloat within software projects. Your insights on this would be really valuable.

Rationale

The xmltodict package was added in e8dea47, and was used in googleads/adwords.py. However, this file was later removed, and upon analysis of the codebase, it was found that it is not currently being utilized within the project. Removing this unused dependency can reduce the overall footprint of the application, mitigate potential security risks, and simplify the dependency management process.

Changes

  • Removed the dependency to the xmltodict PyPI package from the `setup.py file.
  • Removed the corresponding dependnency requirement from the README.

Impact

  • Reduced package size: The removal of this unused dependency will lead to a decrease in the overall size of the installed packages.
  • Simplified dependency tree: Fewer dependencies make the project easier to maintain and can speed up installation.

I have also signed a individual CLA, according to CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant