Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logger.warning instead of deprecated warn #452

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zheplusplus
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@zheplusplus
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@lociii
Copy link

lociii commented Jul 19, 2021

Would be great if this could be merged as it's leading to a DeprecationWarning.

@lociii
Copy link

lociii commented Jan 10, 2022

There are more occurrences and tests to be fixed now.
https://github.com/googleads/googleads-python-lib/search?q=logger.warn

Would be great if we could get rid of these warnings one day. Should be super easy and straight forward.

@BenRKarl BenRKarl changed the base branch from master to main August 23, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants